Zero fails to build on SPARC again, similar to JDK-8186578 (original) (raw)

Erik Joelsson erik.joelsson at oracle.com
Tue Apr 10 16:54:11 UTC 2018

I've found the problem. In JvmFeatures.gmk we have:

ifeq ($(call check-jvm-feature, zero), true)   JVM_CFLAGS_FEATURES += -DZERO -DCC_INTERP -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS)   JVM_LIBS_FEATURES += $(LIBFFI_LIBS)   ifeq ($(OPENJDK_TARGET_CPU), sparcv9)     BUILD_LIBJVM_EXTRA_FILES := $(TOPDIR)/src/hotspot/cpu/sparc/memset_with_concurrent_readers_sparc.cpp   endif endif

The BUILD_LIBJVM_EXTRA_FILES is implicitly trying to set the EXTRA_FILES argument to the BUILD_LIBJVM SetupNativeCompilation call. This used to work because there was no setting of that parameter in the actual call. In a recent change, that parameter is not set to something else, overriding the assignment above.

To fix this, you need to add $(BUILD_LIBJVM_EXTRA_FILES) to the EXTRA_FILES line in CompileJvm.gmk.

/Erik

On 2018-04-10 04:58, John Paul Adrian Glaubitz wrote:

On 04/10/2018 01:37 PM, John Paul Adrian Glaubitz wrote:

@buildd-dev:

I need to build memsetwithconcurrentreaderssparc.cpp for Zero on SPARC as the Zero build now bails out with linker errors: Add the source file in question to EXTRAFILES: glaubitz at deb4g:/srv/glaubitz/hs$ hg diff diff -r b3c09ab95c1a make/hotspot/lib/CompileGtest.gmk --- a/make/hotspot/lib/CompileGtest.gmk Tue Apr 10 12:21:58 2018 +0200 +++ b/make/hotspot/lib/CompileGtest.gmk Tue Apr 10 14:57:05 2018 +0300 @@ -71,7 +71,8 @@ _EXCLUDES := $(JVMEXCLUDES), _ _EXCLUDEFILES := gtestLauncher.cpp, _ _EXCLUDEPATTERNS := $(JVMEXCLUDEPATTERNS), _ _-    EXTRAFILES := $(GTESTFRAMEWORKSRC)/src/gtest-all.cc, _ _+    EXTRAFILES := $(GTESTFRAMEWORKSRC)/src/gtest-all.cc _ + $(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp, __ _EXTRAOBJECTFILES := (filter−out(filter-out %/operatornew(filter−out(OBJSUFFIX), _ _$(BUILDLIBJVMALLOBJS)), _ _CFLAGS := (JVMCFLAGS)−I(JVMCFLAGS) -I(JVMCFLAGS)−I(GTESTFRAMEWORKSRC) _ @@ -109,7 +110,8 @@ _NAME := gtestLauncher, _ _TYPE := EXECUTABLE, _ _OUTPUTDIR := $(JVMOUTPUTDIR)/gtest, _ _-    EXTRAFILES := $(GTESTLAUNCHERSRC), _ _+    EXTRAFILES := $(GTESTLAUNCHERSRC) _ + $(TOPDIR)/src/hotspot/cpu/sparc/memsetwithconcurrentreaderssparc.cpp, __ _OBJECTDIR := $(JVMOUTPUTDIR)/gtest/launcher-objs, _ _CFLAGS := (JVMCFLAGS)−I(JVMCFLAGS) -I(JVMCFLAGS)−I(GTESTFRAMEWORKSRC) _ _-I$(GTESTFRAMEWORKSRC)/include, _ glaubitz at deb4g:/srv/glaubitz/hs$ Causes the object files to be built. But for some reason, the linker is not picking up those object files even though they are located in the object directories of gtest: glaubitz at deb4g:/srv/glaubitz/hs$ find . -name "memsetwithconcurrentreaderssparc.o" ./build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/gtest/objs/memsetwithconcurrentreaderssparc.o ./build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/gtest/launcher-objs/memsetwithconcurrentreaderssparc.o glaubitz at deb4g:/srv/glaubitz/hs$ Adrian

More information about the hotspot-dev mailing list