JEP 328 : Flight Recorder open source preview (original) (raw)
Erik Gahlin erik.gahlin at oracle.com
Sun Apr 15 12:59:11 UTC 2018
- Previous message: JEP 328 : Flight Recorder open source preview
- Next message: JEP 328 : Flight Recorder open source preview
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I think changes to module.info.java in java.base got lost when we re-based the repository.
These changes seem to be missing:
diff --git a/src/java.base/share/classes/module-info.java b/src/java.base/share/classes/module-info.java --- a/src/java.base/share/classes/module-info.java +++ b/src/java.base/share/classes/module-info.java @@ -134,6 +134,8 @@
exports com.sun.security.ntlm to
java.security.sasl;- exports jdk.internal to
jdk.jfr; exports jdk.internal.jimage to jdk.jlink; exports jdk.internal.jimage.decompressor to
@@ -149,16 +151,28 @@ exports jdk.internal.org.objectweb.asm to jdk.jartool, jdk.jlink,
jdk.jfr, jdk.scripting.nashorn, jdk.internal.vm.ci; exports jdk.internal.org.objectweb.asm.tree to
jdk.jlink;
jdk.jlink,jdk.jfr; exports jdk.internal.org.objectweb.asm.util tojdk.jfr, jdk.scripting.nashorn; exports jdk.internal.org.objectweb.asm.commons tojdk.jfr, jdk.scripting.nashorn; exports jdk.internal.org.objectweb.asm.signature to jdk.scripting.nashorn;- exports jdk.internal.org.xml.sax to
jdk.jfr;- exports jdk.internal.org.xml.sax.helpers to
jdk.jfr;- exports jdk.internal.util.xml to
jdk.jfr;- exports jdk.internal.util.xml.impl to
jdk.jfr; exports jdk.internal.math to java.desktop; exports jdk.internal.misc to
@@ -175,6 +189,7 @@ jdk.compiler, // reflective dependency jdk.incubator.httpclient, jdk.jdeps,
jdk.jfr, jdk.jlink, jdk.jshell, jdk.net,
@@ -186,6 +201,7 @@ java.instrument, java.management.rmi, jdk.jartool,
jdk.jfr, jdk.jlink; exports jdk.internal.perf to java.desktop,
We will look into this more closely next week and update the webrev.
Thanks Erik
On 2018-04-15 14:34, Dmitry Samersoff wrote:
Hi Markus,
I'm trying to compile the patch but get following errors: Compiling 1616 files for jdk.localedata .../hs/src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java:60: error: package jdk.internal.misc is not visible import jdk.internal.misc.Unsafe; ^ (package jdk.internal.misc is declared in module java.base, which does not export it to module jdk.jfr) .../hs/src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java:61: error: package jdk.internal.module does not exist import jdk.internal.module.Modules; ^ .../hs/src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java:31: error: package jdk.internal is not visible import jdk.internal.HotSpotIntrinsicCandidate; etc. Any ideas of what could be wrong? -Dmitry On 04/07/2018 01:28 PM, Markus Gronlund wrote: Greetings,
This is a preview of a large part of the source code for JEP 328 : Flight Recorder[1]. Webrev: http://cr.openjdk.java.net/~mgronlun/JEP328FlightRecorder/Preview/webrev/index.html It has been tested on the following platforms: * Linux-x64 * Windows-x64 * MacOSX-x64 We are planning to send out the code for full review in a couple of weeks. At this point, we are preparing changes to move to a single backend, as suggested in the JEP. These will encompass the following: 1. Rename macro INCLUDETRACE to INCLUDEJFR. 2. Remove flag -XX:[+|-]EnableTracing. 3. Cleanup unused elements and attributes by restructuring the trace xml files. 4. Move code under hotspot/share/trace to hotspot/share/jfr/metadata. Thank you Markus and Erik [1] http://openjdk.java.net/jeps/328 PS the patch was generated from the hs repository [2] using change [3] as parent. [2] http://hg.openjdk.java.net/jdk/hs [3] changeset: 49618:947560700a09 user: stefank date: Fri Apr 06 13:55:25 2018 +0200 summary: 8201136: Move GC flags from globals.hpp to GC specific files
- Previous message: JEP 328 : Flight Recorder open source preview
- Next message: JEP 328 : Flight Recorder open source preview
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]