RFR: 8201597: AArch64: Update relocs for CompiledDirectStaticCall (original) (raw)
Andrew Haley aph at redhat.com
Mon Apr 16 16:12:44 UTC 2018
- Previous message: RFR: 8201597: AArch64: Update relocs for CompiledDirectStaticCall
- Next message: RFR (S): 8201326: Renaming ThreadLocalAllocationBuffer end to fast_path_end
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/16/2018 05:03 PM, Andrew Dinn wrote:
On 16/04/18 16:26, Andrew Haley wrote:
http://cr.openjdk.java.net/~aph/8201597/
We're not updating the relocs for OOPs and metadata in compiled static stubs. Fixed thusly: http://cr.openjdk.java.net/~aph/8201597/ Code changes look good. Your webrev doesn't seem to have found a IRA issue yet though.
How odd! Fixed.
Also, you appear to have updated the Red Hat copyright but not the Oracle one. Is that kosher?
Yes.
Every other target except x86 does the same thing, with similar code. I'm therefore baffled that this isn't done in shared code; it certainly could be. Hmm, yes. All of them with minor differences in irrelevant details just to keep you on your toes. What larks, eh!
Right. It could all be in the shared code with an "unless x86" flag.
-- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
- Previous message: RFR: 8201597: AArch64: Update relocs for CompiledDirectStaticCall
- Next message: RFR (S): 8201326: Renaming ThreadLocalAllocationBuffer end to fast_path_end
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]