[11]RFR(S): 8201509: Zero : S390x (S390 and not _LP64) atomic_copy64 inline assembler is wrong. (original) (raw)
Aleksey Shipilev shade at redhat.com
Wed Apr 18 14:29:29 UTC 2018
- Previous message: [11]RFR(S): 8201509: Zero : S390x (S390 and not _LP64) atomic_copy64 inline assembler is wrong.
- Next message: RFR (M) 8201556: Disallow reading oops in ClassLoaderData if unloading
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/18/2018 04:27 PM, Chris Phillips wrote:
Hi Aleksey,
On 18/04/18 05:20 AM, Aleksey Shipilev wrote: On 04/17/2018 05:46 PM, Chris Phillips wrote:
Hi,
Please review this small but significant change to Zero only code related to S390 (31bit) Zero self-build failures. Bug: https://bugs.openjdk.java.net/browse/JDK-8201509 webrev: http://cr.openjdk.java.net/~chrisphi/JDK-8201509/webrev.1 Looks okay to me. In addition to discussion in the bug itself, it seems we can argue it should look similar to the PPC32 && !SPE block above. Which is does, as far as operands are concerned. But, are we sure ld/std is enough to copy 64 bits on S390? I assume "d" is for double in those insns? Yes ld/std memory is double or 64 bits on s390 31bit , the "=&f" specifies an fp reg of at least 64bits.
Okay! Looks good then.
-Aleksey
- Previous message: [11]RFR(S): 8201509: Zero : S390x (S390 and not _LP64) atomic_copy64 inline assembler is wrong.
- Next message: RFR (M) 8201556: Disallow reading oops in ClassLoaderData if unloading
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]