RFR (M) 8201505: Use WeakHandle for ProtectionDomainCacheTable and ResolvedMethodTable (original) (raw)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Apr 18 15:01:42 UTC 2018

Thank you for reviewing this.  The lock ranking code in general needs further work because now we decide rankings in sort of an ad-hoc manner (ie if we get the assert).

thanks, Coleen

On 4/18/18 10:51 AM, Stefan Karlsson wrote:

Hi Coleen,

I haven't reviewed the tests and I can't be 100% sure that the new lock ordering level is correct, but the other parts of the code looks good to me. Thanks, StefanK On 2018-04-18 16:00, coleen.phillimore at oracle.com wrote:

 From some discussions, I've changed ResolvedMethodTable::adjustmethodentries() to have a for loop to avoid the bug in redefinition that this fixed.  See: open webrev at http://cr.openjdk.java.net/~coleenp/8201505.02/webrev Coleen On 4/13/18 8:12 AM, coleen.phillimore at oracle.com wrote: 8193524: Redefining a method that removes use of 1 or more lambda expressions causes the JVM to hang Summary: Remove oop pointers from runtime data structures and fix missing next assignment.

Also, this contains a fix for https://bugs.openjdk.java.net/browse/JDK-8193524 (forgotten next pointer assignment) because I changed that function 3 lines up, and tests contributed by Lois. Tested with mach5 tier1-5. Thanks, Coleen

More information about the hotspot-dev mailing list