RFR (XXS) 8202164: Remove some unneeded BoolObjectClosure* is_alive parameters (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Tue Apr 24 05:39:48 UTC 2018

Looks good (with Kim's suggestions)

StefanK

On 2018-04-24 03:28, Kim Barrett wrote:

On Apr 23, 2018, at 7:12 PM, coleen.phillimore at oracle.com wrote:

See bug for details. open webrev at http://cr.openjdk.java.net/~coleenp/8202164.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8202164 Tested with runThese (lots of class unloading) for all the GCs and with mach5 hs-tier1 and 2. Thanks, Coleen I don’t think I’d call this XXS. Looks good. Needs a couple comment updates; I don't need a new webrev for these. ------------------------------------------------------------------------------ src/hotspot/share/code/nmethod.cpp 1039 flushdependencies(/deleteimmediately/false); The preceding comment needs to be updated; there's no longer a closure involved. ------------------------------------------------------------------------------ src/hotspot/share/code/nmethod.cpp 1364 // During GC deleteimmediately is false, and is used to 1365 // determine liveness of dependees that need to be updated. 1366 if (deleteimmediately || klass->isloaderalive()) { The comment needs to be updated; deleteimmediately doesn't determine liveness. ------------------------------------------------------------------------------

More information about the hotspot-dev mailing list