8185505: AArch64: Port AOT (original) (raw)
Andrew Haley aph at redhat.com
Tue Apr 24 13:26:54 UTC 2018
- Previous message: 8185505: AArch64: Port AOT
- Next message: 8185505: AArch64: Port AOT
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 04/24/2018 06:45 AM, Ningsheng Jian wrote:
Specifically for the link error Yang met, since the stub code (not the GOT cases) and the call site are both in .text section, I think it might be helpful to issue warning/error when generating the relocation entry (before the long time linking phase).
We don't know that the overflow will happen until ink time.
Two more nits:
My Eclipse has some warnings that there are some imports never used in these files: - AArch64JELFRelocObject.java - AMD64JELFRelocObject.java Maybe remove those unused imports in these two files? In file AArch64JELFRelocObject.java, line 110: case Elf64Ehdr.EMAARCH64: // Return RX8664* entries based on relocType Should the comment be RAARCH64* ?
Yes, thanks.
-- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
- Previous message: 8185505: AArch64: Port AOT
- Next message: 8185505: AArch64: Port AOT
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]