RFR(XL): 8199712: Flight Recorder (original) (raw)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Apr 26 17:55:36 UTC 2018

http://cr.openjdk.java.net/~egahlin/8199712.0/src/hotspot/share/classfile/classLoaderData.cpp.udiff.html

We can file another RFE for this but I think you could call post_class_unload_event() from in InstanceKlass and call from inside of InstanceKlass::notify_unload_class.

void ClassLoaderData::unload() {   _unloading = true;

  // Tell serviceability tools these classes are unloading   classes_do(InstanceKlass::notify_unload_class);

Rather than walking through _klasses again during unloading.  I think we should see if this is possible to improve this after this checkin.

http://cr.openjdk.java.net/~egahlin/8199712.0/src/hotspot/share/classfile/systemDictionary.cpp.udiff.html

Then move post_class_load and post_class_define events to instanceKlass.cpp too.

http://cr.openjdk.java.net/~egahlin/8199712.0/src/hotspot/share/utilities/vmError.cpp.udiff.html

Sometimes files are #included inside of #if INCLUDE_JFR and sometimes they aren't.   Should jfr/jfr.hpp have the #if INCLUDE_JFR inside of it?

I reviewed all the shared code in directories classfile, runtime, oops, utilities, except for utilities/ticks.hpp changes, which require an expert for that.

It looks like you have my last change that was in jfrArtifacts.cpp now in

new/src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.hpp

Great!

Thanks, Coleen

On 4/25/18 7:06 AM, Erik Gahlin wrote:

Greetings,

Could I have a review of 8199712: Flight Recorder As mentioned in the preview [1] the tracing backend has been removed. Event metadata has been consolidated into a single XML file and event classes are now generated by GenerateJfrFiles.java. Tests have been run on Linux-x64, Windows-x64 and MaxOSX-x64. For details about the feature, see the JEP: https://bugs.openjdk.java.net/browse/JDK-8193393 Webrev: http://cr.openjdk.java.net/~egahlin/8199712.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199712 [1] http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-April/031359.html Thanks Erik and Markus

More information about the hotspot-dev mailing list