RFR (XS) 8202367: AIX build broken after JDK-8201543 (Modularize C1 GC barriers) (original) (raw)

Langer, Christoph christoph.langer at sap.com
Fri Apr 27 12:13:40 UTC 2018

Thanks, guys, for reviewing so quickly. I have pushed it.

-----Original Message----- From: Doerr, Martin Sent: Freitag, 27. April 2018 13:10 To: Langer, Christoph <christoph.langer at sap.com>; hotspot- dev at openjdk.java.net Cc: Baesken, Matthias <matthias.baesken at sap.com> Subject: RE: RFR (XS) 8202367: AIX build broken after JDK-8201543 (Modularize C1 GC barriers)

Hi Christoph, looks good. Thanks for fixing. Best regards, Martin

-----Original Message----- From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Langer, Christoph Sent: Freitag, 27. April 2018 11:54 To: hotspot-dev at openjdk.java.net Cc: Baesken, Matthias <matthias.baesken at sap.com> Subject: RFR (XS) 8202367: AIX build broken after JDK-8201543 (Modularize C1 GC barriers) Hi, please review a small fix for the AIX build that's broken after JDK-8201543 was pushed. We needs the include gc/shared/cardTable.hpp in gc/shared/c1/cardTableBarrierSetC1.cpp, otherwise the compiler complains about the usage of CardTable like this: "/usr/work/d062122/OpenJDK/jdk/src/hotspot/share/gc/shared/c1/cardTab leBarrierSetC1.cpp", line 70.34: 1540-0062 (S) The incomplete class "CardTable" must not be used as a qualifier. This is the proposed patch: diff -r 25e6d8bb5a6e src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp --- a/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp Fri Apr 27 11:00:57 2018 +0200 +++ b/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp Fri Apr 27 11:44:16 2018 +0200 @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "gc/shared/c1/cardTableBarrierSetC1.hpp" +#include "gc/shared/cardTable.hpp" #include "gc/shared/cardTableBarrierSet.hpp" #include "utilities/macros.hpp" Bug: https://bugs.openjdk.java.net/browse/JDK-8202367 Thanks Christoph

More information about the hotspot-dev mailing list