RFR: 8202381: (Solaris) SIGBUS in # V [libjvm.so+0xcee494] jni_GetIntField+0x224 (original) (raw)

Erik Österlund erik.osterlund at oracle.com
Mon Apr 30 19:46:45 UTC 2018

Hi Kim,

On 2018-04-30 20:31, Kim Barrett wrote:

On Apr 30, 2018, at 11:53 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:

Fixed. I changed it here too. Full: http://cr.openjdk.java.net/~eosterlund/8202381/webrev.01/ Incremental: http://cr.openjdk.java.net/~eosterlund/8202381/webrev.0001/ Changes look good.

Thanks for the review.

However, I noticed a couple of issues that are probably out of scope for getting JDK-8202381 fixed in a timely fashion. Please file a followup RFR or two to address these.

------------------------------------------------------------------------------ tryresolvejobjectinnative slowpath is non-const reference. Seems like it should be const. Sorry I missed this in the review of JDK-8200235. ------------------------------------------------------------------------------ src/hotspot/cpu/sparc/jniFastGetFieldsparc.cpp JNIFastGetField::generatefastgetlongfield JNIFastGetField::generatefastgetfloatfield src/hotspot/cpu/x86/jniFastGetFieldx8664.cpp JNIFastGetField::generatefastgetfloatfield0 Seems like these functions should also be using tryresolvejobjectinnative. Sorry I missed this in the review of JDK-8200235. I didn't look at other platforms to see if there are similar issues elsewhere. ------------------------------------------------------------------------------

I will file a follow-up RFR for this.

Thanks, /Erik

More information about the hotspot-dev mailing list