[11] RFR(S): 8148871: Possible wrong expression stack depth at deopt point (original) (raw)
Tobias Hartmann tobias.hartmann at oracle.com
Thu Mar 1 06:36:42 UTC 2018
- Previous message: [11] RFR(S): 8148871: Possible wrong expression stack depth at deopt point
- Next message: RFR(S): JDK-8196590 Enable docker container related tests for linux AARCH64
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Yumin,
thanks for looking at this.
On 01.03.2018 03:11, yumin qi wrote:
I am not reviewing the change, just wonder if you could modify the comment in the function:
605 JRTLEAF(BasicType, Deoptimization::unpackframes(JavaThread* thread, int execmode)) 606 607 // We are already active int he special DeoptResourceMark any ResourceObj's we 608 // allocate will be freed at the end of the routine. It looks a typo in the comment. 'int he' -> 'in the'
Good catch, I'll fix that comment before pushing.
Best regards, Tobias
On Wed, Feb 28, 2018 at 2:43 PM, <dean.long at oracle.com <mailto:dean.long at oracle.com>> wrote:
This looks good. dl
On 2/28/18 5:25 AM, Tobias Hartmann wrote: Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8148871 <https://bugs.openjdk.java.net/browse/JDK-8148871> http://cr.openjdk.java.net/~thartmann/8148871/webrev.00/ <http://cr.openjdk.java.net/~thartmann/8148871/webrev.00/> The problem is that the stack verification code uses the interpreter oop map to get the stack size of the next instruction. However, for calls, the oop map contains the state after the instruction. With nextmaskexpressionstacksize = 0, the result of 'nextmaskexpressionstacksize - topframeexpressionstackadjustment' is negative and verification fails. For details, see my comment in the bug [1]. The fix is to add a special case for invoke bytecodes and use the parameter size instead of the oop map in that case. Tested with hs-tier1/2 with -XX:+VerifyStack (I hit 8198826 which I'll fix with another patch). Thanks, Tobias [1] https://bugs.openjdk.java.net/browse/JDK-8148871?focusedCommentId=14160003&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14160003 <https://bugs.openjdk.java.net/browse/JDK-8148871?focusedCommentId=14160003&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14160003>
- Previous message: [11] RFR(S): 8148871: Possible wrong expression stack depth at deopt point
- Next message: RFR(S): JDK-8196590 Enable docker container related tests for linux AARCH64
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]