RFR(XS): 8198906: JDK-8196882 breaks VS2013 Win32 builds (original) (raw)
Thomas Stüfe thomas.stuefe at gmail.com
Fri Mar 2 06:28:25 UTC 2018
- Previous message: RFR(XS): 8198906: JDK-8196882 breaks VS2013 Win32 builds
- Next message: RFR(XS): 8198906: JDK-8196882 breaks VS2013 Win32 builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Kim, looks good. Thanks for taking care of this.
..Thomas
On Thu, Mar 1, 2018 at 9:29 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
Please review this change to fix a build failure on Win32 when using VS2013 (and likely earlier). In os::vsnprintf, cast the int result to sizet for comparison with the buffer size, after having verified the result is non-negative.
I'm not sure why this failure doesn't occur with VS2013 Win64 builds. CR: https://bugs.openjdk.java.net/browse/JDK-8198906 Webrev: http://cr.openjdk.java.net/~kbarrett/8198906/open.00/ Testing: VS2013 Win64 still builds. I don't have access to Win32, but the change is pretty simple.
- Previous message: RFR(XS): 8198906: JDK-8196882 breaks VS2013 Win32 builds
- Next message: RFR(XS): 8198906: JDK-8196882 breaks VS2013 Win32 builds
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]