RFR: AArch64: org.openjdk.jcstress.tests.varhandles.DekkerTest fails (original) (raw)

Andrew Dinn adinn at redhat.com
Tue Mar 6 17:01:54 UTC 2018

On 06/03/18 16:24, mark.reinhold at oracle.com wrote:

2018/3/6 4:23:07 -0800, adinn at redhat.com:

Could someone please review the following patch to /shared code/ which fixes an AArch64 breakage that was inadvertently introduced by JDK-8181211:

webrev: http://cr.openjdk.java.net/~adinn/8198950/webrev.00 JIRA: https://bugs.openjdk.java.net/browse/JDK-8198950 The patch applies to jdk/hs. It also applies cleanly to jdk/jdk10. I would like it to be considered for inclusion in jdk10 if at all possible because it patches a critical error in handling of volatile reads that may result in incorrect memory synchronization. Andrew -- thanks for the thorough analysis. So far Tobias and Roland have reviewed your change. I'm not qualified to review it myself, so since it's very late in the game for JDK 10 I'd like to see reviews from at least a couple more C2 committers before we make a call on this. Sure, that's an understandably cautious reaction. Perhaps a Vladimir (or two :-) might be able to take a look?

Thanks very much for even considering this for inclusion in jdk10 at such a late stage.

regards,

Andrew Dinn

Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the hotspot-dev mailing list