RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal (original) (raw)

Brent Christian brent.christian at oracle.com
Tue Mar 6 22:30:01 UTC 2018

Looks good, Katya - thanks. I agree with omitting @bug and @summary from the second @test tag.

Thanks, -Brent

On 3/6/18 1:59 PM, mandy chung wrote:

Running #1 and #2 when Graal is enabled is fine.

For the second @test, does it need @bug and @summary to run?  If not, I suggest to take it out as it's already mentioned in the first @test. Mandy

On 3/6/18 1:45 PM, Ekaterina Pavlova wrote: Hi all,

java/lang/StackWalker/LocalsAndOperands.java runs LocalsAndOperands 3 times with following set of jvm flags:  1) -Xint -DtestUnused=true  2) -Xcomp  3) -Xcomp -XX:-TieredCompilation When running with Graal as JIT (-XX:+TieredCompilation -XX:+UseJVMCICompiler -Djvmci.Compiler=graal) 3rd scenario could take more than 10 minutes and the test could fail by timeout. Actually running LocalsAndOperands with Graal and with "-Xcomp -XX:-TieredCompilation" doesn't provide big benefit and it would be reasonable to disable this scenario in case Graal is enabled. Please review the change. JBS: https://bugs.openjdk.java.net/browse/JDK-8198924 webrev: http://cr.openjdk.java.net/~epavlova//8198924/webrev.00/index.html testing: Tested by running the test in Graal as JIT mode. thanks, -katya p.s.  Igor Ignatyev volunteered to sponsor this change.

More information about the hotspot-dev mailing list