RFR: 8199264: Remove universe.inline.hpp to simplify include dependencies (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 7 22:26:45 UTC 2018

Thanks, Coleen!

StefanK

On 2018-03-07 23:21, coleen.phillimore at oracle.com wrote:

This looks good!  Thank you for doing this. Coleen On 3/7/18 4:59 PM, Stefan Karlsson wrote: Hi all,

Please review this patch to remove universe.inline.hpp. http://cr.openjdk.java.net/~stefank/8199264/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8199264 The main motivation for this patch is to lower the number of .inline.hpp files included from .hpp files. My initial though was to just move the two trivial functions from the universe.inline.hpp into universe.hpp, and get rid of universe.inline.hpp. However, fieldtypeshouldbealigned evaluates to true at the single location it is used, and elementtypeshouldbealigned is only used in arrayOop.hpp, so it was moved there instead. There are a number of places that used to include universe.inline.hpp that now include universe.hpp. I left them all by purpose, to minimize the potential for build breakages. Even removing the universe.hpp include in arrayOop.hpp breaks the build, so I'd like to defer that cleaning to another patch. Thanks, StefanK

More information about the hotspot-dev mailing list