RFR (tedious) 8173070: Remove ValueObj class for allocation subclassing for runtime code (original) (raw)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Mar 8 19:11:20 UTC 2018

On 3/8/18 1:47 PM, Stefan Karlsson wrote:

Looks good. The comment in allocation.hpp is a bit weird, but Coleen has promised that it goes away in subsequent patches. Yes, the last version will be the gc version and that has ValueObj and the comment about ValueObj removed.

Maybe I should have sent the whole thing out, but I wanted to spare people clicking pain (and webrev takes hours for the whole thing).

thanks! Coleen

StefanK On 2018-03-08 19:26, coleen.phillimore at oracle.com wrote:

This change removes VALUEOBJCLASSSPEC as subclass for classes in the runtime code.  I decided to split this into 3 parts to divide the clicking.  See the bug for discussion of why we would like to remove this null class on most platforms in favor of the link time check to disallow Hotspot code from calling global operators new and delete (bug https://bugs.openjdk.java.net/browse/JDK-8198243) Tested with mach5 nightly tests with the full set of changes and mach5 tier1-2 with this set. open webrev at http://cr.openjdk.java.net/~coleenp/8173070.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8173070 I'll update the copyrights with hg commit. Thanks, Coleen

More information about the hotspot-dev mailing list