RFR: 8199220: Zero build broken after 8195103 and 8191102 (was RFR: 8199220: Zero build broken) (original) (raw)

David Holmes david.holmes at oracle.com
Fri Mar 9 07:12:44 UTC 2018

On 9/03/2018 5:03 PM, John Paul Adrian Glaubitz wrote:

On 03/09/2018 12:32 AM, David Holmes wrote:

Ed's using "sponsor" in the hotspot-specific way meaning "someone from Oracle" - so that we can put shared code changes through our builds/tests prior to pushing. :) Ok. I think it should be mentioned then because otherwise I could have pushed it as well. For me, "sponsor" just refers to a person with commit access, at least that's how we define that term in Debian.

Sure, that's why I clarified.

I'm putting this through our (non-zero) builds/tests now. Not that I expect any issues.

It all passed fine btw.

From what Thomas wrote the zero part may still need some work. Btw, during his presentation at FOSDEM, I think Mark talked about CI test machines that can be reached by non-Oracle OpenJDK members. Is that infrastructure already in place? And would that have been sufficient here in order for a non-Oracle sponsor to test and push the changes?

Yes and No. Yes it's in place and is called the "submit" repo [1]. But No it wouldn't be sufficient here because the submit repo is based on jdk/jdk not jdk/hs, so passing there is no guarantee of passing on current jdk/hs. Hence we're still using Oracle-hotspot-sponsors to guide changes to shared code into the hs repo.

Thanks, David

[1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-January/000566.html

Thanks, Adrian

More information about the hotspot-dev mailing list