RFR: 8199220: Zero build broken after 8195103 and 8191102 (was RFR: 8199220: Zero build broken) (original) (raw)

Thomas Stüfe thomas.stuefe at gmail.com
Mon Mar 12 21:32:23 UTC 2018

Reminds me of : http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029289.html

Could this be the same issue?

On Mon 12. Mar 2018 at 21:49, Edward Nevill <edward.nevill at gmail.com> wrote:

On Mon, 2018-03-12 at 19:54 +0000, Thomas Stüfe wrote: > Hi Edward, > > Thanks a lot for the fixing work! > > However, I am not so sure about the change to debug.hpp. Is the point of the Static assert thing not The missing Specialization? In which case the compile error you saw there was a static assert firing... > I may be wrong, maybe Erik could clarify? > > Otherwise the change looks good. Thank you. >

Yes, of course, I see the purpose of the STATICASSERT now. Kind of obvious from the name. The failure is in template <DecoratorSet decorators, typename T> static void verifytypes(){ // If this fails to compile, then you have sent in something that is // not recognized as a valid primitive type to a primitive Access function. STATICASSERT((HasDecorator<decorators, INTERNALVALUEISOOP>::value || // oops have already been validated (IsPointer::value || IsIntegral::value) || IsFloatingPoint::value)); // not allowed primitive type } and the error is /home/ed/openjdk/hs/src/hotspot/share/oops/access.inline.hpp: In instantiation of ‘void AccessInternal::verifytypes() [with long unsigned int decorators = 4096; T = volatile oop]’: I will continue too look at this but would appreciate some help.

Vague sense of deja vu:

http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-November/029289.html

Could this be the same issue?

Thanks, Ed.

More information about the hotspot-dev mailing list