RFR (XS) 8199511: Do not generate g1_{pre|post}_barrier_slow_id without CardTable-enabled barrier set (original) (raw)

Aleksey Shipilev shade at redhat.com
Tue Mar 13 14:02:12 UTC 2018

On 03/13/2018 12:05 PM, Aleksey Shipilev wrote:

g1{pre|post}barrierslowid generation reaches for card table address, but it might not be available if barrier set does not support it. Reliably asserts with Epsilon.

Bug: https://bugs.openjdk.java.net/browse/JDK-8199511 Fix: http://cr.openjdk.java.net/~shade/8199511/webrev.01/ This is arch-specific fix: - c1Runtime1aarch64: copy-pasted the check block from g1prebarrierslowid - c1Runtime1arm: added check block for both g1{pre|post}slowid - c1Runtime1ppc: already implemented - c1Runtime1s390: already implemented - c1Runtime1sparc: already implemented - c1Runtime1x86: copy-pasted the check block from g1prebarrierslowid Testing: x8664 build, Epsilon tests, (running with submit-hs repo now)

submit-hs result came clean (apart from two known failures).

Do I need a sponsor for this?

Definitely need more reviews.

-Aleksey

More information about the hotspot-dev mailing list