RFR (XS) 8199511: Do not generate g1_{pre|post}_barrier_slow_id without CardTable-enabled barrier set (original) (raw)

Per Liden per.liden at oracle.com
Wed Mar 14 08:47:56 UTC 2018

Looks good. For x86 we have the exact same patch in the ZGC repo (not sure why we haven't upstreamed that already, so good that you're doing it)

/Per

On 03/14/2018 09:34 AM, Aleksey Shipilev wrote:

Thank you, Vladimir!

Any non-Red Hat GC people around? -Aleksey On 03/13/2018 07:37 PM, Vladimir Kozlov wrote: Looks good to me but someone from GC should look on it too.

Thanks, Vladimir On 3/13/18 4:05 AM, Aleksey Shipilev wrote: g1{pre|post}barrierslowid generation reaches for card table address, but it might not be available if barrier set does not support it. Reliably asserts with Epsilon.

Bug: https://bugs.openjdk.java.net/browse/JDK-8199511 Fix: http://cr.openjdk.java.net/~shade/8199511/webrev.01/ This is arch-specific fix: - c1Runtime1aarch64: copy-pasted the check block from g1prebarrierslowid - c1Runtime1arm:     added check block for both g1{pre|post}slowid - c1Runtime1ppc:     already implemented - c1Runtime1s390:    already implemented - c1Runtime1sparc:   already implemented - c1Runtime1x86:     copy-pasted the check block from g1prebarrierslowid Testing: x8664 build, Epsilon tests, (running with submit-hs repo now) Thanks, -Aleksey

More information about the hotspot-dev mailing list