RFR: 8199696: Remove Runtime1::arraycopy (original) (raw)

David Holmes david.holmes at oracle.com
Fri Mar 16 02🔞02 UTC 2018

On 16/03/2018 3:53 AM, Vladimir Kozlov wrote:

Hi Erik,

I think it is historical from time when we had Client VM with C1 only and not shared runtime.

So won't 32-bit builds still need it/use it?

David

Shared, x86 and Sparc changes looks good to me.

What platforms you tested on? Thanks, Vladimir On 3/15/18 8:18 AM, Erik Österlund wrote: Hi,

The Runtime1::arraycopy stub appears to only be used on S390 because there is no StubRoutines::genericarraycopy() provided. However, C1 could then simply take a slow path and call its arraycopy stub that performs a native call. Then this logic may be removed. I added an assert on each platform that I think should have a genericarraycopy() stub, and added a branch to the slow path on S390 if there is no such stub. If a stub is eventually added on S390, it should automatically pick that up. Webrev: http://cr.openjdk.java.net/~eosterlund/8199696/webrev.00/ Bug ID: https://bugs.openjdk.java.net/browse/JDK-8199696 Thanks, /Erik

More information about the hotspot-dev mailing list