RFR: 8199739: Use HeapAccess when loading oops from static fields in javaClasses.cpp (original) (raw)

Stefan Karlsson stefan.karlsson at oracle.com
Mon Mar 19 10:13:56 UTC 2018

On 2018-03-16 16:10, Roman Kennke wrote:

Am 16.03.2018 um 15:39 schrieb Stefan Karlsson:

Hi all,

Please review this patch to use HeapAccess<>::oopload instead of oopDesc::loaddecodeheapoop when loading oops from static fields in javaClasses.cpp: http://cr.openjdk.java.net/~stefank/8199739/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8199739 It's necessary to use HeapAccess<>::oopload to inject load barriers for GCs that need them. Thanks, StefanK The change looks good. I haven't checked: are there any stores in there that also need to go through HeapAccess?

I couldn't find anything obvious. I'm prototyping a patch to completely remove the oopDesc::load_decode_* and oopDesc::encode_store_* functions, and didn't find anything in javaClasses that used oopDesc::encode_store_*.

StefanK

Thanks, Roman

More information about the hotspot-dev mailing list