RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands (original) (raw)
Erik Österlund erik.osterlund at oracle.com
Tue Mar 20 10:22:10 UTC 2018
- Previous message: RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands
- Next message: RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Roman,
Is there a good reason why the Access<>::resolve is not performed inside of index_oop_from_field_offset_long instead of its callsites. For example, it looks like barriers are missing in Unsafe_CopySwapMemory0, that you would get for free by putting the resolve barrier in the API used in this file for resolving addresses.
Thanks, /Erik
On 2018-03-19 15:44, Roman Kennke wrote:
SetMemory0 and CopyMemory0 in unsafe.cpp read and write from/to objects, and thus need to resolve their operands via Access::resolve() before accessing them.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199780 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8199780/webrev.00/ I'll say again that I'd prefer resolveforread() and resolveforwrite(), but for now the strong resolve() will suffice. ;-) Can I please get a review? Roman
- Previous message: RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands
- Next message: RFR(XS): JDK-8199780: SetMemory0 and CopyMemory0 in unsafe.cpp need to resolve their operands
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]