Naming restriction for branches in submit-hs (original) (raw)

Volker Simonis volker.simonis at gmail.com
Tue Mar 20 10:21:19 UTC 2018

On Mon, Mar 19, 2018 at 10:49 PM, Christian Tornqvist <christian.tornqvist at oracle.com> wrote:

Hi Volker,

I’ve update the wiki page to reflect what the branch naming restrictions are for the submit repo, you can find the page at: https://wiki.openjdk.java.net/display/Build/Submit+Repo

Hi Christian,

thanks for updating the Wiki! I've tried yesterday with the branch name "JDK-8199698-v2" and it worked fine.

One trivial suggestion regarding the regexp: I think \w already contains the digits so you could actually simplify "^JDK-\d{7}([\w\d-]+)?" to "^JDK-\d{7}([\w-]+)?"

Regards, Volker

Thanks, Christian

On Mar 19, 2018, at 6:45 00AM, jesper.wilhelmsson at oracle.com wrote: Hi Volker, It seems that a . in the branch name might be an issue. This is being investigated. The last build I see with your name on it is from 2018-03-15 17:48. I can see that this is not the one you are looking for. /Jesper On 17 Mar 2018, at 08:55, Volker Simonis <volker.simonis at gmail.com> wrote: Hi Jesper, the Wiki mentions that „only branches starting with “JDK-“ will be built and tested” [1]. I‘ve submitted a branch called „JDK-8199698.v2“ [2] (i.e. the second version of a change after review) yesterday, but it doesn’t seem to be build. Are there any other naming conventions? I‘m pretty sure names like these worked in the first version of the submit repo last year. Thanks, Volker [1] https://wiki.openjdk.java.net/display/Build/Submit+Repo <https://wiki.openjdk.java.net/display/Build/Submit+Repo> [2] http://hg.openjdk.java.net/jdk/submit-hs/rev/60bae43fe453 <http://hg.openjdk.java.net/jdk/submit-hs/rev/60bae43fe453>

More information about the hotspot-dev mailing list