RFR (L, tedious) 8199809: Don't include frame.inline.hpp and other.inline.hpp from .hpp files (original) (raw)
coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Mar 21 00:08:53 UTC 2018
- Previous message: [11] RFR(S): 8199624: [Graal] Blocking jvmci compilations time out
- Next message: [CLOSED] RFR (L, tedious) 8199809: Don't include frame.inline.hpp and other.inline.hpp from .hpp files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Summary: Remove frame.inline.hpp,etc from header files and adjust transitive includes.
Tested with mach5 tier1 on Oracle platforms: linux-x64, solaris-sparc, windows-x64. Built with open-only sources using --disable-precompiled-headers on linux-x64, built with zero (also disable precompiled headers). Roman built with aarch64, and have request to build ppc, etc. (Please test this patch!)
Semi-interesting details: moved SignatureHandlerGenerator constructor to cpp file, moved interpreter_frame_stack_direction() to target specific hpp files (even though they're all -1), pd_last_frame to thread_.cpp because there isn't a thread_.inline.hpp file, lastly moved InterpreterRuntime::LastFrameAccessor into interpreterRuntime.cpp file, and a few other functions moved in shared code.
This is the last of this include file technical debt cleanup that I'm going to do. See bug for more information.
open webrev at http://cr.openjdk.java.net/~coleenp/8199809.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8199809
I'll update the copyrights when I commit.
Thanks, Coleen
- Previous message: [11] RFR(S): 8199624: [Graal] Blocking jvmci compilations time out
- Next message: [CLOSED] RFR (L, tedious) 8199809: Don't include frame.inline.hpp and other.inline.hpp from .hpp files
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]