RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows (original) (raw)
Thomas Stüfe thomas.stuefe at gmail.com
Thu Mar 22 07:53:52 UTC 2018
- Previous message: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Next message: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Erik,
makes sense and looks fine.
..Thomas
On Wed, Mar 21, 2018 at 11:05 PM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
On Windows, we have been linking libjvm.so with -base:0x8000000 since forever. This may have been a good idea on earlier versions of windows, but with VS2017 it generates a warning and with ASLR, the address a given binary is loaded at will vary between runs anyway, so there is little point setting this linker option anymore (since Windows Vista). So I propose we just remove it.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198652 Webrev: http://cr.openjdk.java.net/~erikj/8198652/webrev.01/ /Erik
- Previous message: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Next message: RFR: JDK-8198652: Stop linking with -base:0x8000000 on Windows
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]