RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h (original) (raw)
Kim Barrett kim.barrett at oracle.com
Thu Mar 22 15:52:52 UTC 2018
- Previous message: RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h
- Next message: RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Mar 22, 2018, at 10:34 AM, Robin Westberg <robin.westberg at oracle.com> wrote:
Hi all, Please review the following change that defines WIN32LEANANDMEAN [1] before including windows.h. This marginally improves build times, and makes it possible to include winsock2.h. Issue: https://bugs.openjdk.java.net/browse/JDK-8199736 <https://bugs.openjdk.java.net/browse/JDK-8199736> Webrev: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/> Testing: hs-tier1 Best regards, Robin [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745%28v=vs.85%29.aspx#fasterbuildswithsmallerheaderfiles <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745(v=vs.85).aspx#fasterbuildswithsmallerheaderfiles>
I think the addition of the WIN32_LEAN_AND_MEAN definition should be done through the build system, so that it applies everywhere.
- Previous message: RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h
- Next message: RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]