RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h (original) (raw)

Kim Barrett kim.barrett at oracle.com
Fri Mar 23 18:42:31 UTC 2018

On Mar 23, 2018, at 8:37 AM, Robin Westberg <robin.westberg at oracle.com> wrote:

Hi Kim & Erik, Certainly makes sense to define it from the build system, I’ve updated the patch accordingly: Full: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.01/ Incremental: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00-01/ (Not quite sure if the definition belongs where I put it or a bit later where most other windows-specific JVM flags are defined, but seemed reasonable to put it close to where it is defined for the JDK libraries).

This looks good to me.

Best regards, Robin

On 22 Mar 2018, at 16:52, Kim Barrett <kim.barrett at oracle.com> wrote:

On Mar 22, 2018, at 10:34 AM, Robin Westberg <robin.westberg at oracle.com> wrote:

Hi all, Please review the following change that defines WIN32LEANANDMEAN [1] before including windows.h. This marginally improves build times, and makes it possible to include winsock2.h. Issue: https://bugs.openjdk.java.net/browse/JDK-8199736 <https://bugs.openjdk.java.net/browse/JDK-8199736> Webrev: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/> Testing: hs-tier1 Best regards, Robin [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745%28v=vs.85%29.aspx#fasterbuildswithsmallerheaderfiles <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745(v=vs.85).aspx#fasterbuildswithsmallerheaderfiles> I think the addition of the WIN32LEANANDMEAN definition should be done through the build system, so that it applies everywhere.

More information about the hotspot-dev mailing list