RFR: 8199619: Building HotSpot on Windows should define NOMINMAX (original) (raw)
Kim Barrett kim.barrett at oracle.com
Mon Mar 26 16:34:15 UTC 2018
- Previous message: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX
- Next message: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Mar 26, 2018, at 11:01 AM, Robin Westberg <robin.westberg at oracle.com> wrote:
Hi all, Please review this small change that defines the NOMINMAX macro when building HotSpot on Windows. Issue: https://bugs.openjdk.java.net/browse/JDK-8199619 Webrev: http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8199619/webrev.00/> Testing: building with/without precompiled headers, hs-tier1 Best regards, Robin
Looks good.
This change will have a (easy to resolve) merge conflict with your fix for JDK-8199736, right?
- Previous message: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX
- Next message: RFR: 8199619: Building HotSpot on Windows should define NOMINMAX
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]