RFR(S): 8198915: [Graal] 3rd testcase of compiler/types/TestMeetIncompatibleInterfaceArrays.java takes more than 10 mins (original) (raw)

Volker Simonis volker.simonis at gmail.com
Wed Mar 28 12:32:41 UTC 2018

Hi Tobias,

thanks for the review, Volker

On Wed, Mar 28, 2018 at 10:37 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:

Hi Volker,

looks good to me. Thanks for fixing. Best regards, Tobias On 27.03.2018 19:37, Volker Simonis wrote: Hi,

can I please have a review for the following test-only change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8198915 https://bugs.openjdk.java.net/browse/JDK-8198915 When I wrote this test back in 2015, the WhiteBox API was not powerful enough (or I simply wasn't smart enough to use it :) so I used a lot of -XX options in order to run a method three times in a round where every execution was done at another compilation level (i.e. interpreted, C1 and C2). Unfortunately, the required redefinition of compiler counters and thresholds massively slows down Graal as can be seen in the bug report. I've therefore changed the test to use the Whitbox API to achieve the same test compilation without the need to redefine the global JIT compiler counters and thresholds. Thank you and best regards, Volker

More information about the hotspot-dev mailing list