RFR: 8200251: AArch64::CPUFeature out of sync with VM_Version::Feature_Flag (original) (raw)

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 28 16:52:02 UTC 2018

Looks good.

Thanks, Vladimir

On 3/28/18 6:02 AM, stewartd.qdt wrote:

Please see the updated webrev, where I have also added some flags that were not getting sent over JVMCI.

http://cr.openjdk.java.net/~dstewart/8200251/webrev.01/ Thank you, Daniel -----Original Message----- From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] Sent: Monday, March 26, 2018 12:48 PM To: stewartd.qdt <stewartd.qdt at qualcommdatacenter.com>; hotspot-dev at openjdk.java.net Subject: Re: RFR: 8200251: AArch64::CPUFeature out of sync with VMVersion::FeatureFlag Good. Thanks, Vladimir On 3/26/18 9:24 AM, stewartd.qdt wrote: Please review this webrev [1] which attempts to bring the AArch64::CPUFeature enum (Java) in sync with VMVersion::FeatureFlag enum (C++ enum) for aarch64.

This is in preparation for creating AArch64 some intrinsics for Graal. But I found that the CPUFeature enum was not being transferred over to Graal for AArch64. In attempting to do that I then found out that CPUFeatures was not in sync with the VMVersion::FeatureFlag enum. The bug report is filed at [2]. I am happy to modify the patch as necessary. Regards, Daniel Stewart [1] - http://cr.openjdk.java.net/~dstewart/8200251/webrev.00/ [2] - https://bugs.openjdk.java.net/browse/JDK-8200251

More information about the hotspot-dev mailing list