RFR/RFC 8200438: Non-PCH x86_32 build failure: err_msg is not defined (original) (raw)

Aleksey Shipilev shade at redhat.com
Thu Mar 29 17:04:44 UTC 2018

Me too! Still trying to figure how did that happen. Probably a bug in cross-build?

-Aleksey

On 03/29/2018 06:33 PM, Thomas Stüfe wrote:

I am more confused that your 32bit build pulls sharedRuntimex8664.cpp ..

Thomas On Thu, Mar 29, 2018 at 6:30 PM, Aleksey Shipilev <shade at redhat.com <mailto:shade at redhat.com>> wrote: (correct subject, referencing bug id) Maybe one of the reasons is that x8632 is the cross-compiled build, but x8664 is native, and this is why x8632 fails, when x8664 is not. -Aleksey On 03/29/2018 06:21 PM, Aleksey Shipilev wrote: > Bug: >  https://bugs.openjdk.java.net/browse/JDK-8200438 <https://bugs.openjdk.java.net/browse/JDK-8200438> > > Obvious fix: > > diff -r 5a757c0326c7 src/hotspot/cpu/x86/sharedRuntimex8664.cpp > --- a/src/hotspot/cpu/x86/sharedRuntimex8664.cpp    Thu Mar 29 17:15:26 2018 +0200 > +++ b/src/hotspot/cpu/x86/sharedRuntimex8664.cpp    Thu Mar 29 18:17:58 2018 +0200 > @@ -41,6 +41,7 @@ >  #include "runtime/sharedRuntime.hpp" >  #include "runtime/vframeArray.hpp" >  #include "utilities/align.hpp" > +#include "utilities/formatBuffer.hpp" >  #include "vmversionx86.hpp" >  #include "vmregx86.inline.hpp" >  #ifdef COMPILER1 > > > The non-obvious part (and thus, "RFC") is why x8664 build works fine in the same config. I don't > have the answer for that. > > Testing: x8632 build > > Thanks, > -Aleksey >

More information about the hotspot-dev mailing list