RFR (XL) 8081519 Split globals.hpp to factor out the Flag class (original) (raw)
Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Mar 29 19:17:34 UTC 2018
- Previous message: RFR (XL) 8081519 Split globals.hpp to factor out the Flag class
- Next message: RFR (XL) 8081519 Split globals.hpp to factor out the Flag class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Should we use this opportunity to move all flags related files into separate directory src/hotspot/share/jvmflags ?
Thanks, Vladimir
On 3/29/18 12:01 PM, Gerard Ziemski wrote:
Hi all,
Please review this large and tedious (sorry), but simple fix that accomplishes the following: #1 factor out the command option flag related APIs out of globals.hpp/.cpp into its own dedicated files, i.e. jvmFlag.hpp/.cpp #2 merge Flag (too generic name) and CommandLineFlag classes and rename them as JVMFlag #3 cleanup globals.hpp includes originally added by the JEP-245 Note: the renamed file retain their history, but one needs to add “follow” flag, ex. “hg log -f file” https://bugs.openjdk.java.net/browse/JDK-8081519 http://cr.openjdk.java.net/~gziemski/8081519rev1 Passes Mach5 hstier1-tier5, jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges tests.
cheers
- Previous message: RFR (XL) 8081519 Split globals.hpp to factor out the Flag class
- Next message: RFR (XL) 8081519 Split globals.hpp to factor out the Flag class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]