RFR: 8176717: GC log file handle leaked to child processes (original) (raw)
Thomas Stüfe thomas.stuefe at gmail.com
Fri Mar 30 11:16:47 UTC 2018
- Previous message: RFR: 8176717: GC log file handle leaked to child processes
- Next message: RFR(S/M): 8199472: Fix non-PCH build after JDK-8199319
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Leo,
looks okay. I stated my reservations against adding this function and the platform specific code in its current form before, but I can certainly live with this fix. It follows what we did in os::open(), so it is consistent in that matter.
Thanks for fixing this!
Thomas
(btw, I am not sure which of my "2" Per meant, since I accidentally miscounted my points in the earlier mail.)
On Thu, Mar 29, 2018 at 5:41 PM, Leo Korinth <leo.korinth at oracle.com> wrote:
On 23/03/18 20:03, Leo Korinth wrote:
Hi!
Cross-posting this to both hotspot-dev and hotspot-runtime-dev to get more attention. Sorry. Original mail conversation can be found here: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030637.html I need feedback to know how to continue. Thanks, Leo Hi! Below is a new webrev with Thomas' and Per's suggested name change from: os::fopenretain(const char* path, const char* mode) to: os::fopen(const char* path, const char* mode) Full webrev: http://cr.openjdk.java.net/~lkorinth/8176717/02/ Review and/or comments please! Thanks, Leo
- Previous message: RFR: 8176717: GC log file handle leaked to child processes
- Next message: RFR(S/M): 8199472: Fix non-PCH build after JDK-8199319
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]