RFR (XL) 8081519 Split globals.hpp to factor out the Flag class (original) (raw)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri Mar 30 18:57:27 UTC 2018

http://cr.openjdk.java.net/~gziemski/8081519_rev2/src/hotspot/share/services/diagnosticCommand.cpp.udiff.html

How does this file get the include for JVMFlag?   I don't see jvmFlag.hpp included anywhere but one cpp file.

http://cr.openjdk.java.net/~gziemski/8081519_rev2/src/hotspot/share/runtime/jvmFlag/jvmFlagConstraintsCompiler.hpp.udiff.html

Shouldn't this #include jvmFlag.hpp too?

I can't find anything that includes jvmFlag.hpp except jvmFlag.cpp but there are many files that have JVMFlag::Error in them.

This is a nice refactoring!

thanks, Coleen

On 3/30/18 1:27 PM, Gerard Ziemski wrote:

Hi all,

Please review this large and tedious (sorry), but simple fix that accomplishes the following: #1 factor out the command option flag related APIs out of globals.hpp/.cpp into its own dedicated files, i.e. jvmFlag.hpp/.cpp #2 moved all jvmFlag* files into its own dedicated folder (i.e. src/hotspot/share/runtime/jvmFlag/) #3 merge Flag (too generic name) and CommandLineFlag classes and rename them as JVMFlag #4 cleanup globals.hpp includes originally added by the JEP-245 Note: the renamed file retain their history, but one needs to add “follow” flag, ex. “hg log -f file” https://bugs.openjdk.java.net/browse/JDK-8081519 http://cr.openjdk.java.net/~gziemski/8081519rev2 Passes Mach5 hstier1-tier5, jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges tests.

cheers

More information about the hotspot-dev mailing list