RFR (XXS): 8031776: Remove the unnecessary enum GenRemSet::Name (original) (raw)

Erik Helin erik.helin at oracle.com
Thu Jan 16 16:14:45 UTC 2014

Hi Thomas,

thanks for the review! Please see my reply inline and new webrev at: http://cr.openjdk.java.net/~ehelin/8031776/webrev.01/

On 2014-01-15 20:48, Thomas Schatzl wrote:

On Wed, 2014-01-15 at 16:47 +0100, Erik Helin wrote:

Hi all,

this small patch removes the enum GenRemSet::Name. Since we only have one implementation of GenRemSet, CardTableRS, there is no need for an enum to distinguish between all the implementations of GenRemSet. Webrev: http://cr.openjdk.java.net/~ehelin/8031776/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8031776 Some comments: - the comment above the change in collectorPolicy.cpp still talks about GenRemSet::CardTableRS.

Yeah, I removed the comment, thanks for catching this!

On 2014-01-15 20:48, Thomas Schatzl wrote:

- maybe complete the sentence in the comment for GenRemSet::maxalignmentconstraint() (because we are already touching that code).

Based on our discussion, I changed the comment to:

// Returns any alignment constraint that the remembered set imposes // upon the heap. static uintx max_alignment_constraint();

Thanks, Erik

Looks good otherwise.

Thanks, Thomas

More information about the hotspot-gc-dev mailing list