RFR (S): (7u60,8u20,9) 8032771 Need test to cover JDK-8013132 (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Tue Jan 28 11:53:12 UTC 2014
- Previous message (by thread): RFR (S): (7u60,8u20,9) 8032771 Need test to cover JDK-8013132
- Next message (by thread): RFR (M): (7u60): Backport of 8027476: Improve performance of Stringtable unlink, 8027455: Improve symbol table scan times during gc pauses
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Thomas,
On 2014-01-28 12:38, Thomas Schatzl wrote:
Hi Bengt,
On Tue, 2014-01-28 at 12:27 +0100, Bengt Rutisson wrote: Hi Thomas,
On 2014-01-28 11:38, Thomas Schatzl wrote: Hi Bengt, thanks for the review. On Tue, 2014-01-28 at 10:43 +0100, Bengt Rutisson wrote: Hi Thomas,
Looks good. Two minor nits: The copyright year is 2013. Fixed. I really don't like discussing copyright year. But since this is a new file I think the copyright year should be just 2014. Not "2013, 2014". Sorry, my fault. Fixed. For whatever reason I thought that this was correct, I actually even looked into other files to make the "from-to" line look correct. :( http://cr.openjdk.java.net/~tschatzl/8032771/webrev.2 contains the (hopefully correct) webrev for anyone else interested.
Looks great! Thanks! :)
Bengt
Thomas
- Previous message (by thread): RFR (S): (7u60,8u20,9) 8032771 Need test to cover JDK-8013132
- Next message (by thread): RFR (M): (7u60): Backport of 8027476: Improve performance of Stringtable unlink, 8027455: Improve symbol table scan times during gc pauses
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]