RFR (XXS): 8033106 Wrong predicate for checking whether the correct amount of symbol table entries have been processed in G1 (original) (raw)
Tony Printezis tprintezis at twitter.com
Wed Jan 29 18:19:40 UTC 2014
- Previous message (by thread): RFR (XXS): 8033106 Wrong predicate for checking whether the correct amount of symbol table entries have been processed in G1
- Next message (by thread): RFR (XXS): 8033106 Wrong predicate for checking whether the correct amount of symbol table entries have been processed in G1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thomas,
Looks good.
Tony
On 1/29/14, 11:09 AM, Thomas Schatzl wrote: > Hi all, >> can I have reviews for the following tiny change? >> In the review for the 7u60 backport for 8027476 (stringtable and symbol > table parallelization) Mikael found this issue (thanks!) during review: > the sanity checking code after string table and symbol table scan used > one predicate meant for the string table checking in the symbol table > checks. >> This went unnoticed because the symbol table is scanned always when > calling the method that starts string/symbol table scan, so the second > part of the expression always holds. >> Also fixes the copyright date. >> Webrev: > http://cr.openjdk.java.net/~tschatzl/8033106/webrev/ >> Bug: > https://bugs.openjdk.java.net/browse/JDK-8033106 >> Testing: > jprt >> Thanks, > Thomas >
Tony Printezis | JVM/GC Engineer / VM Team | Twitter
@TonyPrintezis tprintezis at twitter.com
- Previous message (by thread): RFR (XXS): 8033106 Wrong predicate for checking whether the correct amount of symbol table entries have been processed in G1
- Next message (by thread): RFR (XXS): 8033106 Wrong predicate for checking whether the correct amount of symbol table entries have been processed in G1
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]