RFR (M) JDK-8151178: Move the collection set out of the G1 collector policy (original) (raw)
Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 7 14:25:29 UTC 2016
- Previous message (by thread): RFR (M) JDK-8151178: Move the collection set out of the G1 collector policy
- Next message (by thread): RFR (M) JDK-8151178: Move the collection set out of the G1 collector policy
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Mikael,
On Mon, 2016-03-07 at 10:46 +0100, Mikael Gerdin wrote:
Hi all,
Here's a new version of the webrev based on feedback from Jesper and Tom. http://cr.openjdk.java.net/~mgerdin/8151178/version2/ The incremental layout is similar to version1, with the addition of webrev4 which contains the review changes. In this update I also took the liberty to change G1CollectionSet to become a value member in G1CollectedHeap instead of a separately C -heap allocated object. I see no value in it being allocated separately.
some minor issues:
maybe the include changes in g1CollectorState.hpp should be a separate CR, but then again, it's very small.
instead of G1CollectionSet::set_g1p() I would have chosen G1CollectionSet::set_policy() for a name.
as a future cleanup suggestion, maybe the CollectionSetChooser could be one of the first targets, and probably hidden from direct access by the G1CollectorPolicy. Not sure.
g1CollectorPolicy.cpp:977 - superfluous newline ;)
Feel free to implement any of these suggestions, no need for re-review.
Thanks, Thomas
- Previous message (by thread): RFR (M) JDK-8151178: Move the collection set out of the G1 collector policy
- Next message (by thread): RFR (M) JDK-8151178: Move the collection set out of the G1 collector policy
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]