RFR(s): 8150362: G1 base elapsed time prediction is wrong because rs_length prediction is wrong (original) (raw)
sangheon sangheon.kim at oracle.com
Wed Mar 9 19:48:30 UTC 2016
- Previous message (by thread): RFR(s): 8150362: G1 base elapsed time prediction is wrong because rs_length prediction is wrong
- Next message (by thread): RFR(s): 8150362: G1 base elapsed time prediction is wrong because rs_length prediction is wrong
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Mikael,
Thanks for the review.
Sangheon
On 03/09/2016 12:52 AM, Mikael Gerdin wrote:
Hi Sangehon,
On 2016-03-08 19:08, sangheon wrote: Hi all,
Could I have some reviews for this change? We predict remembered set length as follows from G1CollectorPolicy::predictbaseelapsedtimems(sizet pendingcards): sizet rslength = predictrslengthdiff(); This is incomplete and it is inconsistent when compare with the use case of the function from G1CollectorPolicy::calculateyounglisttargetlength(). 'adjrslengths = rslengths + predictrslengthdiff()' In this case, we use rslength + rslengthdiff. I am proposing to use the sum of rslength and rslengthdiff. i.e. 'rs length + rs length diff'. CR: https://bugs.openjdk.java.net/browse/JDK-8150362 Webrev: http://cr.openjdk.java.net/~sangheki/8150362/webrev.00 Looks good. /Mikael Testing: JPRT, some performance tests showed no big difference. Thanks, Sangheon
- Previous message (by thread): RFR(s): 8150362: G1 base elapsed time prediction is wrong because rs_length prediction is wrong
- Next message (by thread): RFR(s): 8150362: G1 base elapsed time prediction is wrong because rs_length prediction is wrong
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]