JDK-8151514: Remove the noisy NOISY debugging code from parCarTableModRefBS.cpp (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Thu Mar 10 07:55:13 UTC 2016
- Previous message (by thread): JDK-8151514: Remove the noisy NOISY debugging code from parCarTableModRefBS.cpp
- Next message (by thread): RFC: Move some code from gc/g1 to gc/shared ?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2016-03-09 14:16, Per Liden wrote:
Looks good.
Thanks, Per!
Bengt
Per On 2016-03-09 13:54, Bengt Rutisson wrote:
Hi everyone, Could I have a couple of reviews for this change? http://cr.openjdk.java.net/~brutisso/8151514/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8151514 In CardTableModRefBSForCTRS::processchunkboundaries() there is a NOISY definition to log some debug messages. Several problems with this macro: * The code inside processchunkboundaries() is very hard to read due to all the NOISY lines. * The logging is done to tty and not the logging framework-. * At some point someone detected a conflict with a preprocessor flag. It is better to remove this macro and just add relevant logging if we every find the need for it. Thanks, Bengt
- Previous message (by thread): JDK-8151514: Remove the noisy NOISY debugging code from parCarTableModRefBS.cpp
- Next message (by thread): RFC: Move some code from gc/g1 to gc/shared ?
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]