RFR: JDK-8151602: Make logging in refillLinearAllocBlockIfNeeded() available (original) (raw)

Thomas Schatzl thomas.schatzl at oracle.com
Thu Mar 10 11:09:18 UTC 2016

Hi Bengt,

On Thu, 2016-03-10 at 11:31 +0100, Bengt Rutisson wrote:

Hi Thomas,

On 2016-03-10 11:28, Thomas Schatzl wrote: > Hi Bengt, > > On Thu, 2016-03-10 at 10:59 +0100, Bengt Rutisson wrote: > > Hi everyone, > > > > Could I have a couple of reviews for this change? > > > > http://cr.openjdk.java.net/~brutisso/8151602/webrev.00 > > https://bugs.openjdk.java.net/browse/JDK-8151602 > > > > In CompactibleFreeListSpace::refillLinearAllocBlockIfNeeded() we > > have > > this code: > > > > if (PrintMiscellaneous && Verbose) { > > if (blk->wordsize == 0) { > > warning("CompactibleFreeListSpace(prologue):: Linear > > allocation > > failure"); > > } > > > > It is a bit strange to guard a warning() this way. Verbose is a > > develop flag so the warning is never printed in product builds. > > This > > is also the only use of PrintMiscellaneous in the GC code. > Wouldn't it be better to just remove the code then (maybe make an > assert out of it)? Apparently nobody ever cared about it anyway. That's fine with me. :) Here's an updated webrev: http://cr.openjdk.java.net/~brutisso/8151602/webrev.01/ (If we go with this I will change the title of the CR to "Remove logging from refillLinearAllocBlockIfNeeded()". )

looks good. While it is a kind of boring question, the addition of the (missing) log.hpp include seems to be somewhat unrelated...

I would not need to re-review fixing this.

Thanks, Thomas

More information about the hotspot-gc-dev mailing list