RFR: JDK-8151603: Use error stream instead of tty for logging before ShouldNotReachHere() (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Thu Mar 10 11:32:02 UTC 2016
- Previous message (by thread): RFR: JDK-8151603: Use error stream instead of tty for logging before ShouldNotReachHere()
- Next message (by thread): RFR: JDK-8151604: Rely on options range checking rather than explict checks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks for the review, Stefan!
Bengt
On 2016-03-10 11:50, Stefan Johansson wrote:
On 2016-03-10 11:45, Bengt Rutisson wrote:
Hi Stefan, Thanks for looking at this!
On 2016-03-10 11:40, Stefan Johansson wrote: Hi Bengt, On 2016-03-10 10:59, Bengt Rutisson wrote:
Hi everyone, Could I have a couple of reviews for this change? http://cr.openjdk.java.net/~brutisso/8151603/webrev.00/ Looks good, just one small thing. Looks like SweepClosure::print() is not used anymore and can be removed from the .hpp-file. Yes, I saw that too. But I intentionally left it in since I figure that its main use if for debugging sessions. We have several other such print() methods. Ok, I'm fine with leaving it then. Thanks, Stefan Thanks, Bengt
Thanks, Stefan https://bugs.openjdk.java.net/browse/JDK-8151603 Some code dumps information on tty before calling ShouldNotReachHere(). With the new logging framework it makes sense to move this to the error stream. Thanks, Bengt
- Previous message (by thread): RFR: JDK-8151603: Use error stream instead of tty for logging before ShouldNotReachHere()
- Next message (by thread): RFR: JDK-8151604: Rely on options range checking rather than explict checks
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]