RFR(s): 8148239: TestSelectDefaultGC.java incorrectly expects G1 on non-server class machines (original) (raw)
Per Liden per.liden at oracle.com
Mon Mar 14 12:09:42 UTC 2016
- Previous message (by thread): RFR(s): 8148239: TestSelectDefaultGC.java incorrectly expects G1 on non-server class machines
- Next message (by thread): RFR(s): 8148239: TestSelectDefaultGC.java incorrectly expects G1 on non-server class machines
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks Kirill, good catch.
Updated webrev: http://cr.openjdk.java.net/~pliden/8148239/webrev.1/
cheers, Per
On 2016-03-14 12:59, Kirill Zhaldybin wrote:
Per,
Just a bit of nit-picking: copyright should be "2015, 2016". Regards, Kirill On 14.03.2016 14:49, Kirill Zhaldybin wrote: Per,
Looks great, but since you are ignoring externally specified GC may you could add @requires vm.gc=="null"? Thank you. Regards, Kirill On 14.03.2016 14:06, Per Liden wrote: Hi,
The TestSelectDefaultGC incorrectly assumes that "Server VM" means it's running on a server class machine. This patch removes that assumption and instead explicitly passes AlwaysActAsServerClassMachine and NeverActAsServerClassMachine to the VM to influence the machine type and in turn the default GC selection. Bug: https://bugs.openjdk.java.net/browse/JDK-8148239 Webrev: http://cr.openjdk.java.net/~pliden/8148239/webrev.0/ thanks, Per
- Previous message (by thread): RFR(s): 8148239: TestSelectDefaultGC.java incorrectly expects G1 on non-server class machines
- Next message (by thread): RFR(s): 8148239: TestSelectDefaultGC.java incorrectly expects G1 on non-server class machines
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]