RFR: 8151781: DirtyCardQueue::apply_closure is unused (original) (raw)

Kim Barrett kim.barrett at oracle.com
Mon Mar 14 17:41:32 UTC 2016

On Mar 14, 2016, at 3:41 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:

Hi Kim, On 2016-03-14 07:51, Kim Barrett wrote: Please review this change to remove an unused function, with some followup cleanup enabled by that removal.

Removed DirtyCardQueue::applyclosure, which is unused. That allowed applyclosuretobuffer to be moved from DirtyCardQueue public static to DirtyCardQueueSet private ordinary member function. Making it ordinary gives it access to the set's buffer size, so that value no longer needs to be passed as an argument by the callers. Also removed the default value for workeri from CardTableEntryClosure::docardptr, since all callers pass that argument. Default parameter values for virtual functions are a well-known source of problems. CR: https://bugs.openjdk.java.net/browse/JDK-8151781 Webrev: http://cr.openjdk.java.net/~kbarrett/8151781/webrev.00/ Looks good.

Thanks.

Thanks, Bengt

Testing: JPRT, Aurora default tests.

More information about the hotspot-gc-dev mailing list