RFR(S): 8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser (original) (raw)

Jon Masamitsu jon.masamitsu at oracle.com
Mon Mar 14 19:06:14 UTC 2016

A couple of copyright updates needed.

http://cr.openjdk.java.net/~mgerdin/8151637/webrev.0/src/share/vm/gc/g1/collectionSetChooser.cpp.frames.html http://cr.openjdk.java.net/~mgerdin/8151637/webrev.0/src/share/vm/gc/g1/collectionSetChooser.hpp.frames.html

Otherwise, looks good.

Jon

On 03/14/2016 04:07 AM, Mikael Gerdin wrote:

Hi all,

Currently when the CSetChooser needs to be injected with new regions the collector policy is responsible for calling a bunch of semi internal functions on the chooser and setting up some closures which are only relevant to the cset chooser. I've moved that code into the collection set chooser instead. I wasn't entirely clear on how the API for rebuild() should look since under the hood the closures go and access the G1CollectedHeap instance through the static in order to access the heap iteration method but since that has not changed in this patch I've left it as is. Bug: https://bugs.openjdk.java.net/browse/JDK-8151637 Webrev: http://cr.openjdk.java.net/~mgerdin/8151637/webrev.0/ Testing: JPRT Thanks /Mikael

More information about the hotspot-gc-dev mailing list