RFR(S): 8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser (original) (raw)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Mar 15 09:36:59 UTC 2016


Hi Mikael,

On Tue, 2016-03-15 at 10:19 +0100, Mikael Gerdin wrote:

Hi Thomas,

On 2016-03-15 09:36, Thomas Schatzl wrote: > Hi Mikael, > > On Mon, 2016-03-14 at 12:07 +0100, Mikael Gerdin wrote: > > Hi all, > > [...] > > Bug: https://bugs.openjdk.java.net/browse/JDK-8151637 > > Webrev: http://cr.openjdk.java.net/~mgerdin/8151637/webrev.0/ > > Testing: JPRT > > looks good. > > Maybe the moved closure code (closure naming, g1 prefix, camelcase > member names, make ParKnownGarbageHRClosure a local class to the > task, > etc) could be touched up a little. > > Feel free to ignore though. In this case I'd prefer to leave it as is and move on to other changes. Thanks for the review.

sure, no problem.

Thomas



More information about the hotspot-gc-dev mailing list