RFR: (S): 8142935: Adding old gen regions does not consider available free space (original) (raw)

Derek White derek.white at oracle.com
Mon Mar 21 13:54:52 UTC 2016

Hi Tom,

On 3/19/16 9:10 AM, Tom Benson wrote:

Hi Derek, Thanks for taking a look. I see that the link under the webrev text was bad due to cut/paste, so here's a good one for any new readers: Webrev: http://cr.openjdk.java.net/~tbenson/8142935/webrev/

On 3/18/2016 6:22 PM, Derek White wrote:

My main question is that it looks like the accounting: incbytesusedbefore incbyteslivebefore bytesusedbefore byteslivedbefore are a summary of the bytes used and live in the young regions. In the new test in G1CollectionSet::finalizeoldpart(), I don't see that it's accounting for the live bytes of the old regions it already added to the cset. For example if the young regions had no live data, then we might still add too many old regions to the cset? The update to byteslivebefore at line 100 of g1CollectionSet.cpp is inside addoldregion(), so I think that should account for them. Thanks,

OK, I see it. I agree with Kim's comment to, otherwise looks great.

More information about the hotspot-gc-dev mailing list