RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Thu Mar 31 13:39:53 UTC 2016
- Previous message (by thread): RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp
- Next message (by thread): RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Thomas,
On 2016-03-31 15:10, Thomas Schatzl wrote:
Hi all,
can I have quick reviews for this change that adds a missing include to the file in question? The HeapRegionBounds class inherits from AllStatic, which is in memory/allocation.hpp that is not included. Some future changes break because of this oversight. For current sources there is no difference. Note that strictly we should probably also include stddef.h for sizet, but looking through other sources, this is (almost) never done. So I refrained from doing so here too. CR: https://bugs.openjdk.java.net/browse/JDK-8153193 Webrev: http://cr.openjdk.java.net/~tschatzl/8153193/webrev/
Looks good.
Bengt
Testing: local testing
Thanks, Thomas
- Previous message (by thread): RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp
- Next message (by thread): RFR (XXS): 8153193: Missing includes in gc/g1/heapRegionBounds.hpp
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]