Make reserved_size for compressed class space and metaspace respect the ergo-initialized CompressedClassSpaceSize flag value (original) (raw)

Yasumasa Suenaga yasuenag at gmail.com
Fri Dec 8 05:44:45 UTC 2017

Hi Man,

CompressedClassSpaceSize might be modified by FLAG_SET_ERGO. So I think you need to move set_compressed_class_space_size() only.

Thanks,

Yasumasa

2017-12-08 3:42 GMT+09:00 Man Cao <manc at google.com>:

Hello,

This is a friendly ping. Could anyone review or sponsor this change? It's just a two-liner change. -Man On Thu, Nov 30, 2017 at 2:03 PM, Man Cao <manc at google.com> wrote:

I realized that the email attachment is probably dropped by the mailing list, so below is the inlined patch. --- old/src/hotspot/share/memory/metaspace.cpp 2017-11-29 14:56:59.017118444 -0800 +++ new/src/hotspot/share/memory/metaspace.cpp 2017-11-29 14:56:58.657121375 -0800 @@ -3321,9 +3321,6 @@ MinMetaspaceExpansion = aligndownbounded(MinMetaspaceExpansion, commitalignment); MaxMetaspaceExpansion = aligndownbounded(MaxMetaspaceExpansion, commitalignment); - CompressedClassSpaceSize = aligndownbounded(CompressedClassSpaceSize, reservealignment); - setcompressedclassspacesize(CompressedClassSpaceSize); - // Initial virtual space size will be calculated at globalinitialize() sizet minmetaspacesz = VIRTUALSPACEMULTIPLIER * InitialBootClassLoaderMetaspaceSize; @@ -3341,6 +3338,8 @@ minmetaspacesz); } + CompressedClassSpaceSize = aligndownbounded(CompressedClassSpaceSize, reservealignment); + setcompressedclassspacesize(CompressedClassSpaceSize); } void Metaspace::globalinitialize() { Best, Man On Wed, Nov 29, 2017 at 3:21 PM, Man Cao <manc at google.com> wrote:

Hello, This patch is a follow-up fix for https://bugs.openjdk.java.net/browse/JDK-8087291 This patch moves the call to setcompressedclassspacesize() after the flag value for CompressedClassSpaceSize is ergo-initialized, fixing the issue that the reserved size for compressed class space and metaspace is excessively large when MaxMetaspaceSize is set to a small value. More discussion about it is available here: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2017-November/025200.html This code patch is attached. Could anyone review and/or sponsor this patch? Best, Man

More information about the hotspot-gc-dev mailing list